-
Notifications
You must be signed in to change notification settings - Fork 37
Check internet availability #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fabik111
wants to merge
13
commits into
arduino-libraries:master
Choose a base branch
from
fabik111:check-access-internet
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Check internet availability #137
fabik111
wants to merge
13
commits into
arduino-libraries:master
from
fabik111:check-access-internet
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memory usage change @ cfe83cb
Click for full report table
Click for full report CSV
|
Memory usage change @ 218698d
Click for full report table
Click for full report CSV
|
218698d
to
e853987
Compare
Memory usage change @ e853987
Click for full report table
Click for full report CSV
|
Memory usage change @ cce1a4c
Click for full report table
Click for full report CSV
|
…emoving redundant constructor with strings
cce1a4c
to
0314cf5
Compare
Memory usage change @ 0314cf5
Click for full report table
Click for full report CSV
|
use ping for all connectivity compile fix for esp8266 and esp32 remove check ping for mkrnb
0314cf5
to
54b93d6
Compare
Memory usage change @ 54b93d6
Click for full report table
Click for full report CSV
|
andreagilardoni
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce a step of validation that the board has access to internet before giving the "Connected" result.
The PR requires this PR on MKRNB lib